Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-pyvserver - Python interface to the Linux-VServer kernel interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250463 lxtnow@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lxtnow@xxxxxxxxx ------- Additional Comments From lxtnow@xxxxxxxxx 2007-08-02 13:10 EST ------- # Release tag: As you have an snapshot package which's post-released. 1.20070723git639686%{?dist} instead of 0.0.20070723git639686 # Package name: As a package of python module, a differente name scheme should be set. however the upstream source has already named the base package name of its source with "py"vserver which's enough. So move the name (including spec file name) to pyvserver only. # Source0: I think that you should mention on spec file it's an snapshop link/source # %build stage: As noarch package, the flags CFLAGS= SHOULD be remove (fc.the comment above it's there for reminder). # files: your package own others directoris which're own by other packages. All directories/sub-one which __python-sitelib contains. SHOULD be fix. # Changelog: version changelog need to be fix due tu first issues in this comment. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review