https://bugzilla.redhat.com/show_bug.cgi?id=1396761 --- Comment #7 from Till Maas <opensource@xxxxxxxxx> --- Sorry for the delay on my side this time :-/ Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= Unfortunately there are still some issues: :-/ - The guidelines now seemt to require an outline for the licenses - The checks are ignored instead and the upstream bug is closed - The timestamps of the files modified in %prep are not preserved ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Please add a comment like: # MIT: rofi # Public Domain: rofi-sensible-terminal rofi-theme-selector [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rofi- debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. The tests are ignored and the upstream bug reporst is closed due to inactivity [!]: Packages should try to preserve timestamps of original installed files. %prep changes files without preserving the timestamps [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rofi-1.3.1-1.fc24.x86_64.rpm rofi-debuginfo-1.3.1-1.fc24.x86_64.rpm rofi-1.3.1-1.fc24.src.rpm rofi.x86_64: W: spelling-error Summary(en_US) dmenu -> menu, d menu, madmen rofi.x86_64: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular rofi.x86_64: W: spelling-error %description -l en_US superswitcher -> super switcher, super-switcher, switcher rofi.x86_64: W: spelling-error %description -l en_US xlib -> lib, glib, x lib rofi.x86_64: W: spelling-error %description -l en_US pango -> pang, pangs, panto rofi.x86_64: W: no-manual-page-for-binary rofi-theme-selector rofi.src: W: spelling-error Summary(en_US) dmenu -> menu, d menu, madmen rofi.src: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular rofi.src: W: spelling-error %description -l en_US superswitcher -> super switcher, super-switcher, switcher rofi.src: W: spelling-error %description -l en_US xlib -> lib, glib, x lib rofi.src: W: spelling-error %description -l en_US pango -> pang, pangs, panto 3 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: rofi-debuginfo-1.3.1-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory rofi.x86_64: W: spelling-error Summary(en_US) dmenu -> menu, d menu, madmen rofi.x86_64: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular rofi.x86_64: W: spelling-error %description -l en_US superswitcher -> super switcher, super-switcher, switcher rofi.x86_64: W: spelling-error %description -l en_US xlib -> lib, glib, x lib rofi.x86_64: W: spelling-error %description -l en_US pango -> pang, pangs, panto rofi.x86_64: W: no-manual-page-for-binary rofi-theme-selector 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- rofi (rpmlib, GLIBC filtered): /bin/bash libc.so.6()(64bit) libcairo.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libstartup-notification-1.so.0()(64bit) libxcb-ewmh.so.2()(64bit) libxcb-icccm.so.4()(64bit) libxcb-randr.so.0()(64bit) libxcb-render.so.0()(64bit) libxcb-util.so.1()(64bit) libxcb-xinerama.so.0()(64bit) libxcb-xkb.so.1()(64bit) libxcb-xrm.so.0()(64bit) libxcb.so.1()(64bit) libxkbcommon-x11.so.0()(64bit) libxkbcommon-x11.so.0(V_0.5.0)(64bit) libxkbcommon.so.0()(64bit) libxkbcommon.so.0(V_0.5.0)(64bit) rtld(GNU_HASH) rofi-debuginfo (rpmlib, GLIBC filtered): Provides -------- rofi: rofi rofi(x86-64) rofi-debuginfo: rofi-debuginfo rofi-debuginfo(x86-64) Source checksums ---------------- https://github.com/DaveDavenport/rofi/releases/download/1.3.1/rofi-1.3.1.tar.gz : CHECKSUM(SHA256) this package : da61d2da7e5f4f354da2bfb50ec06b0613d6aba6cf09346a86177f3351db2326 CHECKSUM(SHA256) upstream package : da61d2da7e5f4f354da2bfb50ec06b0613d6aba6cf09346a86177f3351db2326 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1396761 Buildroot used: fedora-24-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
