https://bugzilla.redhat.com/show_bug.cgi?id=1477197 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: 52d5a1f8c3bace4bae6d25b123a00213d6de027cac0da6666f1ed4f7b6bebd18) is original. Ok. Summary verified from lib/Email/Address/XS.pm. Ok. Description verified from lib/Email/Address/XS.pm. Ok. FIX: Remove the article before `groups' word in the description. License verified from lib/Email/Address/XS.pm, README, dovecot-parser.c. Ok. FIX: This packages bundles dovecot code (dovecot-parser.c contains functions and data types from various dovecot files sources). You have to provide `bundled()' RPM symbol per bundling policy. FIX: Build-require `findutils' (perl-Email-Address-XS.spec:44). FIX: Do not build-require `perl(utf8)', it's not used on modern Perl. All tests pass. Ok. $ rpmlint perl-Email-Address-XS.spec ../SRPMS/perl-Email-Address-XS-1.00-1.fc27.src.rpm ../RPMS/x86_64/perl-Email-Address-XS-* perl-Email-Address-XS.src: W: spelling-error %description -l en_US formatter -> formatted, for matter, for-matter perl-Email-Address-XS.x86_64: W: spelling-error %description -l en_US formatter -> formatted, for matter, for-matter perl-Email-Address-XS-debuginfo.x86_64: E: debuginfo-without-sources perl-Email-Address-XS-debugsource.x86_64: W: no-documentation perl-Email-Address-XS-debugsource.x86_64: W: devel-file-in-non-devel-package /usr/src/debug/perl-Email-Address-XS-1.00-1.fc27.x86_64/Email-Address-XS.c perl-Email-Address-XS-debugsource.x86_64: W: devel-file-in-non-devel-package /usr/src/debug/perl-Email-Address-XS-1.00-1.fc27.x86_64/dovecot-parser.c perl-Email-Address-XS-debugsource.x86_64: W: devel-file-in-non-devel-package /usr/src/debug/perl-Email-Address-XS-1.00-1.fc27.x86_64/dovecot-parser.h 4 packages and 1 specfiles checked; 1 errors, 6 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Email-Address-XS-1.00-1.fc27.x86_64.rpm drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/lib/.build-id/02 lrwxrwxrwx 1 root root 67 Aug 2 13:11 /usr/lib/.build-id/02/8268dc0e43ac0a16909ec7c57b902f32d48b7b -> ../../../../usr/lib64/perl5/vendor_perl/auto/Email/Address/XS/XS.so drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/lib64/perl5/vendor_perl/Email drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/lib64/perl5/vendor_perl/Email/Address -rw-r--r-- 1 root root 15804 Feb 18 15:24 /usr/lib64/perl5/vendor_perl/Email/Address/XS.pm drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/lib64/perl5/vendor_perl/auto/Email drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/lib64/perl5/vendor_perl/auto/Email/Address drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/lib64/perl5/vendor_perl/auto/Email/Address/XS -rwxr-xr-x 1 root root 32280 Aug 2 13:11 /usr/lib64/perl5/vendor_perl/auto/Email/Address/XS/XS.so drwxr-xr-x 2 root root 0 Aug 2 13:11 /usr/share/doc/perl-Email-Address-XS -rw-r--r-- 1 root root 281 Feb 18 15:24 /usr/share/doc/perl-Email-Address-XS/Changes -rw-r--r-- 1 root root 1892 Feb 18 15:24 /usr/share/doc/perl-Email-Address-XS/README -rw-r--r-- 1 root root 4454 Aug 2 13:11 /usr/share/man/man3/Email::Address::XS.3pm.gz File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Email-Address-XS-1.00-1.fc27.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.26()(64bit) 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(:VERSION) >= 5.6.0 1 perl(base) 1 perl(Carp) 1 perl(Exporter) 1 perl(overload) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Email-Address-XS-1.00-1.fc27.x86_64.rpm | sort -f | uniq -c 1 perl(Email::Address::XS) = 1.00 1 perl-Email-Address-XS = 1.00-1.fc27 1 perl-Email-Address-XS(x86-64) = 1.00-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Email-Address-XS-1.00-1.fc27.x86_64.rpm Binary dependencies resolvable. Ok. The package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20966619). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
