https://bugzilla.redhat.com/show_bug.cgi?id=1476773 --- Comment #3 from Matthias Runge <mrunge@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 56 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/1476773-python- subunit2sql/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-subunit2sql , python2-subunit2sql-graph , python-subunit2sql- doc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.2 starting (python version = 3.6.2)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.2 INFO: Mock Version: 1.4.2 Finish: chroot init INFO: installing package(s): /home/mrunge/review/1476773-python-subunit2sql/results/python2-subunit2sql-1.8.0-2.fc27.noarch.rpm /home/mrunge/review/1476773-python-subunit2sql/results/python-subunit2sql-doc-1.8.0-2.fc27.noarch.rpm /home/mrunge/review/1476773-python-subunit2sql/results/python2-subunit2sql-graph-1.8.0-2.fc27.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 27 --disableplugin=local --setopt=deltarpm=False install /home/mrunge/review/1476773-python-subunit2sql/results/python2-subunit2sql-1.8.0-2.fc27.noarch.rpm /home/mrunge/review/1476773-python-subunit2sql/results/python-subunit2sql-doc-1.8.0-2.fc27.noarch.rpm /home/mrunge/review/1476773-python-subunit2sql/results/python2-subunit2sql-graph-1.8.0-2.fc27.noarch.rpm Rpmlint ------- Checking: python2-subunit2sql-1.8.0-2.fc27.noarch.rpm python2-subunit2sql-graph-1.8.0-2.fc27.noarch.rpm python-subunit2sql-doc-1.8.0-2.fc27.noarch.rpm python-subunit2sql-1.8.0-2.fc27.src.rpm python2-subunit2sql.noarch: W: spelling-error Summary(en_US) subunit -> sub unit, sub-unit, suburbanite python2-subunit2sql.noarch: W: spelling-error %description -l en_US subunit -> sub unit, sub-unit, suburbanite python2-subunit2sql.noarch: W: spelling-error %description -l en_US api -> API, pi, ape python2-subunit2sql.noarch: W: no-manual-page-for-binary sql2subunit python2-subunit2sql.noarch: W: no-manual-page-for-binary sql2subunit-2 python2-subunit2sql.noarch: W: no-manual-page-for-binary sql2subunit-2.7 python2-subunit2sql.noarch: W: no-manual-page-for-binary subunit2sql python2-subunit2sql.noarch: W: no-manual-page-for-binary subunit2sql-2 python2-subunit2sql.noarch: W: no-manual-page-for-binary subunit2sql-2.7 python2-subunit2sql.noarch: W: no-manual-page-for-binary subunit2sql-db-manage python2-subunit2sql.noarch: W: no-manual-page-for-binary subunit2sql-db-manage-2 python2-subunit2sql.noarch: W: no-manual-page-for-binary subunit2sql-db-manage-2.7 python2-subunit2sql-graph.noarch: W: spelling-error Summary(en_US) subunit -> sub unit, sub-unit, suburbanite python2-subunit2sql-graph.noarch: W: spelling-error Summary(en_US) subpackage -> sub package, sub-package, package's python2-subunit2sql-graph.noarch: E: summary-too-long C Command to Read a subunit file or stream and put the data in a SQL DB graph subpackage python2-subunit2sql-graph.noarch: W: spelling-error %description -l en_US subunit -> sub unit, sub-unit, suburbanite python2-subunit2sql-graph.noarch: W: spelling-error %description -l en_US api -> API, pi, ape python2-subunit2sql-graph.noarch: W: no-documentation python2-subunit2sql-graph.noarch: W: no-manual-page-for-binary subunit2sql-graph python2-subunit2sql-graph.noarch: W: no-manual-page-for-binary subunit2sql-graph-2 python2-subunit2sql-graph.noarch: W: no-manual-page-for-binary subunit2sql-graph-2.7 python-subunit2sql-doc.noarch: W: summary-not-capitalized C subunit2sql documentation python-subunit2sql-doc.noarch: W: spelling-error %description -l en_US subunit -> sub unit, sub-unit, suburbanite python-subunit2sql-doc.noarch: W: spelling-error %description -l en_US api -> API, pi, ape python-subunit2sql.src: W: spelling-error Summary(en_US) subunit -> sub unit, sub-unit, suburbanite python-subunit2sql.src: W: spelling-error %description -l en_US subunit -> sub unit, sub-unit, suburbanite python-subunit2sql.src: W: spelling-error %description -l en_US api -> API, pi, ape 4 packages and 0 specfiles checked; 1 errors, 26 warnings. Requires -------- python-subunit2sql-doc (rpmlib, GLIBC filtered): python2-subunit2sql (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-SQLAlchemy python-alembic python-dateutil python-oslo-config python-oslo-db python-pbr python-six python-stevedore python-subunit python2-subunit2sql-graph (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-matplotlib python-pandas python2-subunit2sql Provides -------- python-subunit2sql-doc: python-subunit2sql-doc python2-subunit2sql: python-subunit2sql python2-subunit2sql python2.7dist(subunit2sql) python2dist(subunit2sql) python2-subunit2sql-graph: python2-subunit2sql-graph Source checksums ---------------- https://files.pythonhosted.org/packages/source/s/subunit2sql/subunit2sql-1.8.0.tar.gz : CHECKSUM(SHA256) this package : 9bfad07b696b5d1cbf037fe214976236bb6912f0d9bb8dd770d8453166696ffd CHECKSUM(SHA256) upstream package : 9bfad07b696b5d1cbf037fe214976236bb6912f0d9bb8dd770d8453166696ffd Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1476773 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby While this looks ok, there is still something fishy. I couldn't build it in mock on different machines. The provided scratch-build does not contain any python3 packages. Please shorten the summary for python2-subunit2sql-graph -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
