[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #25 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
I have found some issues:

1) The latest release is 0.25.1. Please update your package (v0.24) for the
latest version.

2) The "-unit-test-devel" subpackage Requires "%{name}-devel" (which doesn't
exist, and leads to installation errors), and this should be replaced by
"golang-%{provider}-%{project}-%{repo}-devel".

3) The "-devel" subpackage doesn't own all directories that it should
("/usr/share/gocode/src/github.com/gohugoio/hugo" - the hugo sources root
directory - and all subdirectories of it are unowned [1]). This shouldn't
happen when you use the scripts generated by gofed.

4) You should use %global instead of %define in line 32 of the .spec file
according to the packaging guidelines.


Otherwise, the package looks good.


[1] Note: Directories without known owners:
     /usr/share/gocode/src/github.com/gohugoio/hugo/helpers,
     /usr/share/gocode/src/github.com/gohugoio/hugo/commands,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/inflect,
     /usr/share/gocode/src/github.com/gohugoio/hugo/i18n,
     /usr/share/gocode/src/github.com/gohugoio/hugo/create,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/collections,
     /usr/share/gocode/src/github.com/gohugoio/hugo/releaser,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/tplimpl,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/math,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/transform,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/cast,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/strings,
     /usr/share/gocode/src/github.com/gohugoio,
     /usr/share/gocode/src/github.com/gohugoio/hugo/transform,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/safe,
     /usr/share/gocode/src/github.com/gohugoio/hugo/media,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/crypto,
     /usr/share/gocode/src/github.com/gohugoio/hugo,
     /usr/share/gocode/src/github.com/gohugoio/hugo/bufferpool,
     /usr/share/gocode/src/github.com/gohugoio/hugo/hugolib,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/fmt,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/data,
     /usr/share/gocode/src/github.com/gohugoio/hugo/cache,
     /usr/share/gocode/src/github.com, (this is expected)
     /usr/share/gocode/src, (this is expected)
     /usr/share/gocode/src/github.com/gohugoio/hugo/output,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/internal,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/compare,
     /usr/share/gocode/src/github.com/gohugoio/hugo/hugofs,
     /usr/share/gocode, (this is expected)
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl,
     /usr/share/gocode/src/github.com/gohugoio/hugo/source,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/encoding,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/os,
     /usr/share/gocode/src/github.com/gohugoio/hugo/parser,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/time,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/lang,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/partials,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/images,
     /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/urls

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux