https://bugzilla.redhat.com/show_bug.cgi?id=1476489 --- Comment #2 from Zamir SUN <sztsian@xxxxxxxxx> --- Hi, thanks for the review. > - If you're installing a .desktop file, you must validate it in %check: IMO this is not a general desktop file. It is for xfce use only. I checked various xfce plugins, and none of them implement a validate. For example, http://pkgs.fedoraproject.org/cgit/rpms/xfce4-calculator-plugin.git/tree/xfce4-calculator-plugin.spec http://pkgs.fedoraproject.org/cgit/rpms/xfce4-battery-plugin.git/tree/xfce4-battery-plugin.spec What's more, it will fail to rpmbuild if a validate is added. > - debuginfo-without-sources: The same as I stated in 1471806, rpmlint passed on Fedora 26. > - hardcoded-library-path: I know where this comes from. I have a line > mv %{buildroot}/usr/lib %{buildroot}/%{_libdir} I find the plugin always goes into /usr/lib regardless of architecture, so I hardcoded a mv here. The static library problem is fixed. Updated in place. Spec URL: https://zsun.fedorapeople.org/pub/pkgs/xfce4-statusnotifier-plugin/xfce4-statusnotifier-plugin.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/xfce4-statusnotifier-plugin/xfce4-statusnotifier-plugin-0.1.0-1.fc26.src.rpm HTH. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
