https://bugzilla.redhat.com/show_bug.cgi?id=1476438 --- Comment #2 from Jake Hunsaker <jhunsaker@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > Hello, > > A few points: > - since you are the developer, a LICENSE file would be nice ofr it to be > included in the package. Done. > - Fedora 25 introduced the macro pythonXdist, you can therefore require > paramiko with: python2dist(paramiko) See > https://fedoraproject.org/wiki/Packaging: > Python#Requires_and_BuildRequires_with_standardized_names Cool, didn't know that. Updated. > - You define a sitelib macro but it's not necessary as there is already a > %{python2_sitelib} macro available. Updated. > - The name of the bin is clustersosreport but the name used in the man page > makes it seems the command is clustersos Looks like somehow the updated man page never got committed when I changed the binary from clustersos to clustersosreport. Thanks for pointing that out. Updated. Updated the download locations Spec URL: http://people.redhat.com/jhunsake/clustersos/clustersos.spec SRPM URL: http://people.redhat.com/jhunsake/clustersos/clustersos-1.1.1-1.fc25.src.rpm Sanity check koji build still passes: https://koji.fedoraproject.org/koji/taskinfo?taskID=20904114 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
