[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1476085



--- Comment #9 from Michael Cullen <michael@xxxxxxxxxxxxxxxxx> ---
Ok, nearly there. A couple of things about that doc subpackage though.

One of the review checklist items is:
* License file installed when any subpackage combination is installed.

it's possible to install the doc subpackage without getting the license file.
Conceptually I can see why you might just want the docs (though it's unlikely!)
so maybe the best thing to do is to include the license file in the docs
package as well?

Also, I wonder if the doc package should be noarch? 

Other than that it looks good. that pthread thing looks ugly and I can't help
thinking there's something else going on there but it'll do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux