https://bugzilla.redhat.com/show_bug.cgi?id=1476014 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Michael Cullen from comment #4) > Thanks! I thought I saw something saying the iconcache update wasn't needed > now but I must have been mistaken. Well, it's like the other scriptlets that are no longer needed, so I don't know why this one hasn't been eliminated. I expect someone will get around that at some point. > You didn't mention it, but after taking a look at your review (which I'll > keep an eye on even though someone else got there before me with comments) I > was reminded to add gcc-c++ as a BuildRequires - I suspect it's already > pulled in via qt5-devel but it's probably better to be explicit! It is, and I should have noticed it was missing. Shame on me. There are just two very small issues left. First, BuildRequires: gzip isn't necessary. It is on the Exceptions list and hasn't been superseded by any other guidelines, unlike the gcc/gcc-c++ case. Second, the package needs to have Requires: hicolor-icon-theme, not BuildRequires: hicolor-icon-theme. This is to ensure that the icon directories exist at install/run time. You don't need them at build time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
