https://bugzilla.redhat.com/show_bug.cgi?id=1476085 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Michael Cullen from comment #5) > * libsemigroups.x86_64: W: spelling-error %description -l en_US initialise > -> initialize > > yeah I know, I'm british too but the package guidelines are for american > english spellings :-) Actually, I'm a Yank. :-) I've gotten into the bad habit of ignoring rpmlint's complaints about misspelled words, because it is nearly always wrong. I'll rededicate myself to looking through the list of words for those rare cases where it actually finds a misspelled word. > * libsemigroups.x86_64: W: undefined-non-weak-symbol > /usr/lib64/libsemigroups.so.0.0.0 pthread_create > > looks to me like you're missing the -pthread compiler option Actually, a peek at the build logs show that the -pthread compiler option is being passed. Apparently that does not imply linking with -lpthread, at least for a shared library. I've forced the issue by hacking up the Makefile to add -lpthread, which fixes the problem. Thanks for spotting that! > I'd agree about the docs going into a separate subpackage Done. I also added the standard lines in %build to eliminate hardcoded rpaths. New URLs: Spec URL: https://jjames.fedorapeople.org/libsemigroups/libsemigroups.spec SRPM URL: https://jjames.fedorapeople.org/libsemigroups/libsemigroups-0.3.1-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
