https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #2 from Ye Cheng <18969068329@xxxxxxx> --- (In reply to Iwicki Artur from comment #1) > >Release: 0%{?dist} > The Release: tag should start at 1. Fixed as Release: 1%{?dist} in release tag nd changelog > The Group: tag should not be used. Group tags are removed > >Source0: https://github.com/websnarf/bstrlib/archive/master.zip > Refer to a git tag or commit instead. Fixed as Source0: https://github.com/websnarf/bstrlib/archive/v%{updatever}.zip > >%{_libdir}/bstrlib/ > >%{_includedir}/bstrlib/ Fixed by adding %dir %{_libdir}/bstrlib/, %dir %{_includedir}/bstrlib/ > Also, I believe that the use of both %{buildroot} and ${RPM_BUILD_ROOT} is > discouraged; it should be one or the other. Fixed mix use of %{buildroot} and ${RPM_BUILD_ROOT} (described in https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS) by replacing %{buildroot} with ${RPM_BUILD_ROOT} Built in copr rawhide, sorry for the inconvenience of changing URLs. New srpm URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-rawhide-i386/00584721-bstrlib/bstrlib-1.0.0-1.fc27.src.rpm New spec URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-rawhide-i386/00584721-bstrlib/bstrlib.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
