https://bugzilla.redhat.com/show_bug.cgi?id=1476085 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Robert-André. (In reply to Robert-André Mauchin from comment #1) > - gcc-c++ is not needed as a BuildRequires. See: > http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 That page is out of date. See https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B for the latest guidelines. > - You can use the macro %{__rm} instead of rm alone. I can, but I don't like those macros. They seem to me to add verbosity for no gain. > - You should use the %make_build macro instead of make %{?_smp_mflags} Okay. > - Per guidelines, "large documentation must go in a -doc subpackage. Large > could be size (~1MB) or number of files". Your documentation has a large > number of files (320) and is nearly 3MB in size, it is thus considered > "large" and should be in a separate -doc subpackage. Okay, I will fix this when I get home from work and upload a new package. Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
