https://bugzilla.redhat.com/show_bug.cgi?id=1475483 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- http://wiki.qt.io/Qbs → https:// http://download.qt.io/official_releases/ → https:// > LGPLv2 and LGPLv3, with exceptions I think this should be "LGPLv2 with exceptions and LGPLv3 with exceptions" (following https://fedoraproject.org/wiki/Licensing:Main#Software_License_List). > # qbs was previously packaged as part of qt-creator, using the qt-creator version > Obsoletes: %{name} < 0:4.4.0 Shouldn't this be "qt-creator < 0:4.4.0" instead? Also, note that the new qt-creator package should have Obsoletes: %{name} < 0:4.4.0, so called self-obsoletes, so that both packages are installed during upgrade. s/Examples for projects/Example projects/ https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries are needed. Looks good otherwise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
