[Bug 1467047] Review Request: nuvola-app-bandcamp - Bandcamp for Nuvola Player 3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1467047

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
Well, everything looks good, but the plugin appdata are wrong (an they are
actually wrong for nuvola-app-amazon-cloud-player and I am afraid they are
wrong for all other plugins you have submitted for review).

1) The <extends> tag needs to refer to nuvola player desktop file, so this
should be the right version:

~~~
<extends>eu.tiliado.Nuvola.desktop</extends>
~~~

2) The <name> tag should be something user readable, so "AppBandcamp" is
probably not the best description. I'd say that better would be just "Bandcamp"
in this case.

In theory, you should be able to test this using "killall gnome-software;
gnome-software --verbose" but for me, the plugins does not show up under the
nuvola, but they shows independently :/

I am going to approve the package now, but please resolve this prior importing
the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux