https://bugzilla.redhat.com/show_bug.cgi?id=1419332 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + package name is OK + license is acceptable for Fedora (GPLv3) + license is specified correctly + builds and installs OK + Requires/Provides/BuildRequires look OK + no scriptlets necessary + build flags are honoured + rpmlint shows nothing useful - no docs and no license: there's a LICENSE file, and some documentation files, not sure if those are useful. Please add least add %license LICENSE. CuteLogger is bundled. It is not packaged for Fedora, so according to the guidelines [https://fedoraproject.org/wiki/Bundled_Software_policy], a tag should be added: Provides: bundled(CuteLogger) If you know the version, also add "= <version>", but from a quick look at the sources, I don't see any version string there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
