https://bugzilla.redhat.com/show_bug.cgi?id=1470656 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: 7a82fe44a2658d7ccc57f51a69954719473f066bf9148396b9f49b86593b56f5) is original. Ok. Summary verified from lib/Regexp/Stringify.pm. Ok. Description verified from lib/Regexp/Stringify.pm. Ok. License verified from LICENSE and lib/Regexp/Stringify.pm. Ok. No XS code, noarch BuildArch is Ok. Test::Pod::Coverage and Pod::Coverage::TrustPod and Test::Pod are not used. Ok. FIX: Build-require `perl(blib)' for tests (t/00-compile.t:19). All tests pass. Ok. $ rpmlint perl-Regexp-Stringify.spec ../SRPMS/perl-Regexp-Stringify-0.06-1.fc27.src.rpm ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm perl-Regexp-Stringify.src: W: spelling-error %description -l en_US stringification -> stratification, transmogrification, gentrification perl-Regexp-Stringify.noarch: W: spelling-error %description -l en_US stringification -> stratification, transmogrification, gentrification 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Jul 24 12:53 /usr/share/doc/perl-Regexp-Stringify -rw-r--r-- 1 root root 711 Oct 29 2016 /usr/share/doc/perl-Regexp-Stringify/Changes -rw-r--r-- 1 root root 431 Oct 29 2016 /usr/share/doc/perl-Regexp-Stringify/README drwxr-xr-x 2 root root 0 Jul 24 12:53 /usr/share/licenses/perl-Regexp-Stringify -rw-r--r-- 1 root root 18367 Oct 29 2016 /usr/share/licenses/perl-Regexp-Stringify/LICENSE -rw-r--r-- 1 root root 2390 Jul 24 12:53 /usr/share/man/man3/Regexp::Stringify.3pm.gz drwxr-xr-x 2 root root 0 Jul 24 12:53 /usr/share/perl5/vendor_perl/Regexp -rw-r--r-- 1 root root 5221 Oct 29 2016 /usr/share/perl5/vendor_perl/Regexp/Stringify.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(:VERSION) >= 5.10.1 1 perl(Exporter) 1 perl(re) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Regexp::Stringify) = 0.06 1 perl-Regexp-Stringify = 0.06-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. The package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20711448). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
