https://bugzilla.redhat.com/show_bug.cgi?id=1474033 --- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> --- > %global rel 1 > %global version 1.3.3274 Completely pointless definition and redefinition of macros for various reasons: 1) You define %rel only to use it once in the spec file. 2) You also use %release and not only %rel. 3) The "Release" tag implicitly defines %release, so both macros would be the same. 4) The "Version" tag implicitly defines %version. You redefine %version. Further, the dist tag is missing: https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning > %global __check_files %{nil} Comment/rationale missing! > %bcond_with valgrind No-op due to nothing related within the spec file. > Summary: Unified Communication X That's only what the UCX acronym stands for. The %description could explain that and expand on the summary, while the %summary could tell a bit more: Summary: Communication framework for data centric and high-performance applications > Group: Development/Libraries No. The group for system runtime library packages is "System Environment/Libraries" for decades. On the contrary, "Development/Libraries" is for -devel packages, for example. > Source: %{name}-%{version}.tar.gz https://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source > ExclusiveArch: aarch64 ppc64le x86_64 https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support > Requires(post): /sbin/ldconfig > Requires(postun): /sbin/ldconfig Implicit and automatic with /sbin/ldconfig scriptlets for a *very* long time. > %description > %description devel Odd that the -devel package contains the more detailed description. The base package also contains more than libraries, lacking an explanation. > %build > ./contrib/configure-release \ That's a configure script for which you really want to use the %configure macro. See "rpm -E %configure" on what it does. > mkdir -p %{buildroot}%{_sysconfdir}/ld.so.conf.d/ > echo %{_libdir} > %{buildroot}%{_sysconfdir}/ld.so.conf.d/ucx.conf No, %_libdir is in the default search path list for runtime libs. > %clean > rm -rf %{buildroot} https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > %files > %{_libdir}/lib*.so.* > %{_bindir}/uc* > %{_datadir}/ucx/perftest/* https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership > %{_sysconfdir}/ld.so.conf.d/ucx.conf Superfluous. > %files devel > %{_includedir}/uc* > %{_libdir}/lib*.a https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries > %changelog > * Mon Jul 3 2017 Andrey Maslennikov <andreyma@xxxxxxxxxxxx> 1.3 > - Fedora package created Not matching %version. Please take a look at the fedora-review tool. Point it at this ticket via "fedora-review -b 1474033" and let it fetch the latest package files to help you with lots of automated reviewing tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
