https://bugzilla.redhat.com/show_bug.cgi?id=1419330 --- Comment #9 from sensor.wen@xxxxxxxxx --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00582584-deepin-menu/deepin-menu.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00582584-deepin-menu/deepin-menu-3.1.5-1.git3ab1c65.fc25.src.rpm Task: https://copr.fedorainfracloud.org/coprs/mosquito/deepin/build/582584/ add Deepin for OnlyShowIn key: https://bugs.freedesktop.org/show_bug.cgi?id=101878 (In reply to Robin Lee from comment #7) > [!]: Package is named according to the Package Versioning Guidelines. > Note: Git commit should not be included in the release tag if it is the > proper released version. > https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning > And the source url can be written using Git tags: > https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "GPL (v3 or later)", "Unknown or generated". 25 files have > unknown license. > [-]: shebang removing procedure can be improved with respect to > > https://fedoraproject.org/wiki/ > Packaging_tricks#Remove_shebang_from_Python_libraries > [!]: ldconfig is redundant > [!]: Removing OnlyShowIn is bad. One can submit a request to freedesktop to > add a new recognized desktop environment, like: > https://bugs.freedesktop.org/show_bug.cgi?id=51258 > [-]: It is better to use relative path for symlink. > [-]: It is better to separate changelog entries with empty lines. > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Repeat_the_old_version_release_with_a_new_entry -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
