https://bugzilla.redhat.com/show_bug.cgi?id=1419317 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- %description should end in ".". You don't need %doc README.md and %license LICENSE in the main subpackage, because it's already included in %{name}-data anyway, and %{name}-data is required by the main subpackage. + package name is OK + license is acceptable for Fedora (GPLv3) + license is specified correctly + builds and installs OK + Provides/Requires/BuildRequires appear to be correct + scriptlets are OK (at least I think so, there's many different upgrade/downgrade/install/uninstall paths). OK, I think it's all good, apart from some cosmetic issues. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
