https://bugzilla.redhat.com/show_bug.cgi?id=1308488 --- Comment #14 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- Manual checks: ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. Pass. [ ]: Package contains no static executables. Pass. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Pass. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MPL (v2.0)", "*No copyright* CC by-sa (v4.0)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* MPL (v2.0)". 446 files have unknown license. Detailed output of licensecheck in /home/vitaly/1308488-mediaconch/licensecheck.txt Pass. But some of source files don't contain license preamble. You should ask upstream to add it. [ ]: License file installed when any subpackage combination is installed. Pass. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Pass. [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/mediaconch [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/mediaconch Fail. Directory ownership /etc/mediaconch can be fixed during import to Fedora SCM. [ ]: %build honors applicable compiler flags or justifies otherwise. Pass. [ ]: Package contains no bundled libraries without FPC exception. Pass. [ ]: Changelog in prescribed format. Pass. [ ]: Sources contain only permissible code or content. Pass. [ ]: Development files must be in a -devel package Pass. [ ]: Package uses nothing in %doc for runtime. Pass. [ ]: Package consistently uses macros (instead of hard-coded directory names). Pass. [ ]: Package is named according to the Package Naming Guidelines. Pass. [ ]: Package does not generate any conflict. Pass. [ ]: Package obeys FHS, except libexecdir and /usr/target. Pass. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. Pass. [ ]: Requires correct, justified where necessary. Pass. [ ]: Spec file is legible and written in American English. Pass. [ ]: Package contains systemd file(s) if in need. Pass. [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in mediaconch-gui Pass. [ ]: Useful -debuginfo package or justification otherwise. Pass. [ ]: Package is not known to require an ExcludeArch tag. Pass. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. Pass. [ ]: Package complies to the Packaging Guidelines Pass. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
