https://bugzilla.redhat.com/show_bug.cgi?id=1472748 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addressed are Ok. Source0 archive (SHA-256: 7c00e8b7213e8b7faf3a0040d46994d7007be4fd501b430d994bc7a8b5806332) is original. Ok. Summary verified from lib/Tk/FontDialog.pm. Ok. Description is Ok. License verified from lib/Tk/FontDialog.pm. Ok. No XS code, noarch BuildArch is Ok. BuildRequires are Ok. All tests pass. Ok. $ rpmlint perl-Tk-FontDialog.spec ../SRPMS/perl-Tk-FontDialog-0.18-1.fc27.src.rpm ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm perl-Tk-FontDialog.spec:30: W: comparison-operator-in-deptoken font(:lang=en) perl-Tk-FontDialog.src:30: W: comparison-operator-in-deptoken font(:lang=en) 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Jul 19 14:15 /usr/share/doc/perl-Tk-FontDialog -rw-r--r-- 1 root root 1568 Mar 22 07:10 /usr/share/doc/perl-Tk-FontDialog/Changes -rw-r--r-- 1 root root 318 Jul 12 2012 /usr/share/doc/perl-Tk-FontDialog/README -rw-r--r-- 1 root root 3866 Jul 19 14:15 /usr/share/man/man3/Tk::FontDialog.3pm.gz drwxr-xr-x 2 root root 0 Jul 19 14:15 /usr/share/perl5/vendor_perl/Tk -rw-r--r-- 1 root root 24652 Mar 22 07:10 /usr/share/perl5/vendor_perl/Tk/FontDialog.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(strict) 1 perl(Tk) >= 800 1 perl(Tk::Font) 1 perl(Tk::HList) 1 perl(Tk::ItemStyle) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Tk::FontDialog) = 0.18 1 perl-Tk-FontDialog = 0.18-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. The package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20610823). Ok. The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
