[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421041

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
             Blocks|177841 (FE-NEEDSPONSOR)     |
              Flags|                            |fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
So now the requires are:
/usr/bin/perl
/usr/bin/python3
gettext
perl(Config::Tiny)
perl(Exporter::Tiny)
perl(XML::LibXML)
perl(XML::LibXML::PrettyPrint)
qt5-linguist
Looks good.

> /bin/perl desktop_ts/src/desktop_ts_convert.pl --help
> /bin/python3 src/generate_mo.py --help
> /bin/python3 src/update_pot.py --help

No need to use the full path. We assume that the tools like perl and python3
are in $PATH.

rpmlint:
deepin-gettext-tools.noarch: W: spelling-error %description -l en_US msgid ->
MSG
deepin-gettext-tools.noarch: W: spelling-error %description -l en_US ini ->
uni, in, ii
deepin-gettext-tools.noarch: W: spelling-error %description -l en_US po -> PO,
pew, op
deepin-gettext-tools.src: W: spelling-error %description -l en_US msgid -> MSG
deepin-gettext-tools.src: W: spelling-error %description -l en_US ini -> uni,
in, ii
deepin-gettext-tools.src: W: spelling-error %description -l en_US po -> PO,
pew, op
Bogus warnings.

deepin-gettext-tools.noarch: W: no-manual-page-for-binary
deepin-desktop-ts-convert
deepin-gettext-tools.noarch: W: no-manual-page-for-binary deepin-generate-mo
deepin-gettext-tools.noarch: W: no-manual-page-for-binary
deepin-policy-ts-convert
deepin-gettext-tools.noarch: W: no-manual-page-for-binary deepin-update-pot
That's OK. It's nice to have man pages, but it's certainly not required.

2 packages and 0 specfiles checked; 0 errors, 10 warnings.

+ package name is OK
+ latest version
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ builds and installs OOK
+ Provides/Requires/BuildRequires appear correct
+ no scriptlets are needed
+ %check is present and passes.

Package is APPROVED.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux