Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Astro-FITS-CFITSIO - Perl extension for using the cfitsio library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250342 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-08-01 18:23 EST ------- This one is pretty simple as well. The only question I have is why you don't package up the examples as documentation. But that's really up to you. * source files match upstream: bbeb6fd3b17b290842a88a8179c2526abae21fa67172295385a742b51bbfab70 Astro-FITS-CFITSIO-1.05.tar.gz * package meets naming and versioning guidelines (ugly caps and all) * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: CFITSIO.so()(64bit) perl(Astro::FITS::CFITSIO) = 1.05 perl-Astro-FITS-CFITSIO = 1.05-1.fc8 = libcfitsio.so.0()(64bit) perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) * %check is present and all tests pass: 149 / 149 tests passed (100.0%) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review