https://bugzilla.redhat.com/show_bug.cgi?id=1468768 --- Comment #6 from Michael Cronenworth <mike@xxxxxxxxxx> --- (In reply to Ben Rosser from comment #2) > Apologies for not getting to this sooner. No problem at all. Thanks for looking! > * rpmlint complains that you are shipping a PEM certificate. However looking > at the domoticz documentation, it explicitly references that domoticz will > use this cert if a separate one is not provided, so this is probably fine. Yes, the cert is just shipped by the source tarball and it is up to the user to create their own and place it in /var/lib/domoticz, which is what the systemd unit file expects. > * As per > https://fedoraproject.org/wiki/Packaging:UsersAndGroups?rd=Packaging/ > UsersAndGroups#Dynamic_allocation, please add "Requires(pre): shadow-utils" > since this package creates a user and a group. Fixed. > They look compiled to me. :) I would include the BRs just to be safe. That's rpmbuild helping too much. I'll include it anyway. > * fedora-review also complains about the perl scripts, but I think this one > is safe to ignore, assuming the Perl scripts are also not used for anything. > > Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; > echo $version)) missing?" Correct. > * I'm dubious about the licensing being okay-- there are a lot of different > licenses listed in the full licensecheck output [1]. Are you sure that, for > example, the Boost-licensed files (marked by fedora-review as "BSL") in the > "webserver" directory aren't being compiled? If they are, the license must > be annotated accordingly. > > To be explicit about this, I would recommend removing the bits that are > bundled in %prep and cross-checking with the licensecheck output. > > Further complicating things, there is a large amount of content in > /usr/share/domoticz/www, including a number of gzip-compressed JS libraries > in /usr/share/domoticz/www/js, and a variety of fonts scattered throughout > the directory as well. Please: > > - Investigate unbundling the fonts. Hopefully this is possible, but if not > please confirm that the fonts are appropriately licensed via "ttname" as per > the fonts policy [2]. > > - Go through the bundled JS libs, identify their licenses, add bundled > provides, and amend the License: tag of the package accordingly. (I would > bet most are MIT licensed). Having had to do this myself before, I know it's > mostly frustrating busywork; I'm sorry to have to ask for it, but the > guidelines are clear. :( These issues should be corrected. Spec: http://michael.cronenworth.com/RPMS/domoticz.spec SRPM: http://michael.cronenworth.com/RPMS/domoticz-3.5877-2.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
