https://bugzilla.redhat.com/show_bug.cgi?id=1468768 --- Comment #1 from Michael Cronenworth <mike@xxxxxxxxxx> --- I'll comment on what fedora-review flags as issues: - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions The self-updater script is in /usr/share, yes, and I will disable it, but it is useless. - Package contains BR: python2-devel or python3-devel False positive. The python scripts shipped are not compiled or used and are for extra functionality not supported in the app and I include them if any advanced users which to use them. - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 This is required now. Fedora-review is out of date. https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text The license is contained in "License.txt" and is correct. Fedora-review also complains about the results of licensecheck, but the bundled software that is flagged is not shipped, and the license should be OK. - [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. The /usr/share data is required by the app at runtime. Splitting it into a sub-package would net zero gains. Additionality this clause has been removed from the Guidelines. I can't find it. The review should be a single pass check-off, unless I have missed something badly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
