https://bugzilla.redhat.com/show_bug.cgi?id=1308488 --- Comment #10 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > %if 0%{?fedora} || 0%{?rhel} > 7 Can be replaced to: %if 0%{?rhel} < 7 BuildRequires: pkgconfig(Qt5WebKit) %else BuildRequires: pkgconfig(Qt5WebEngine) %endif Group should be removed from main package and all it's subpackages. > Requires: libzen%{?_isa} >= %{libzen_version} > Requires: libmediainfo%{?_isa} >= %{libmediainfo_version} Rpmlint will throw an error on this rows. Library dependencies should be resolved automatically via rpmbuild. > make install-strip DESTDIR=%{buildroot} You don't need to strip binaries manually. Rpmbuild will do it for you and generate -debuginfo subpackage. > install -dm 755 %{buildroot}%{_datadir}/kde4/services/ServiceMenus/ > install -m 644 -p Project/GNU/GUI/mediaconch-gui.kde4.desktop %{buildroot}%{_datadir}/kde4/services/ServiceMenus/mediaconch-gui.desktop This should be moved into -kde subpackage with dependency on KDE. > install -dm 755 %{buildroot}%{_datadir}/apps/konqueror/servicemenus > install -m 644 -p Project/GNU/GUI/mediaconch-gui.kde3.desktop %{buildroot}%{_datadir}/apps/konqueror/servicemenus/mediaconch-gui.desktop This should be removed as KDE3 already reached it's EOL and dropped from Fedora repositories. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
