https://bugzilla.redhat.com/show_bug.cgi?id=1468949 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- The package looks good now. I have one final nitpick which you can fix when importing: you have the %global modname greenlet macro, but you don't use it in %prep: %setup -q -n greenlet-%{version} or in %files: %files -n python%{python3_pkgversion}-greenlet %license LICENSE LICENSE.PSF %doc AUTHORS NEWS README.rst %doc doc/greenlet.txt benchmarks %{python3_sitearch}/greenlet.cpython-%{python3_version_nodots}m.so %{python3_sitearch}/greenlet-%{version}-py%{python3_version}.egg-info %files -n python%{python3_pkgversion}-greenlet-devel %license LICENSE LICENSE.PSF %doc AUTHORS NEWS README.rst %{_includedir}/python%{python3_version}m/greenlet Please use the macro consistently or drop it. Anyway, the package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
