Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-08-01 14:25 EST ------- For 1.4.0-2: * Dependency for main/subpackage - Usually the dependency for main/subpackage must be version-release specific. * Redundant BuildRequires - cairo-devel requires freetype-devel - cairo-devel requires pkgconfig (also see below) * pkgconfig dependency - Packages containing pkgconfig .pc file must have "Requires: pkgconfig" * "#include" message in header files - Check the dependency of -devel package, especially check what files the header files in -devel package needs to "include". The initial check can be done by: ---------------------------------------------------------------- $ grep -h 'include ' `rpm -ql guile-cairo-devel` | sort | uniq #include <cairo-svg.h> #include <cairo.h> #include <guile-cairo-enum-types.h> #include <guile-cairo-smob-types.h> #include <guile-cairo-vector-types.h> #include <libguile.h> ---------------------------------------------------------------- And actually /usr/include/guile-cairo/guile-cairo.h contains: ---------------------------------------------------------------- 26 27 #include <cairo.h> 28 #include <libguile.h> 29 ---------------------------------------------------------------- , which means that -devel package must require cairo-devel and guile-devel. * Documents - Please add the following: ----------------------------------------------------------------- NEWS TODO ----------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review