https://bugzilla.redhat.com/show_bug.cgi?id=1470580 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Pavel Valena from comment #1) > Package Review > ============== > - Will you be unretiring the package in two commits? The first one being > spec file checkout to 533041868174e19827d4a7374333f20e4b0f377d. I am not sure about this yet. It depends how the repository will look. I might do just `fedpkd import` at the end. > - Is there any reason for inclusion of `cucumber.yml`? Good question. But I keep the file as I keep gemfiles, Rakefile, etc. But will reconsider this prior import. > - I'd recommend you to use %{gem_name} in `%exclude > %{gem_instdir}/factory_girl.gemspec` I am not big fan of this. It does not provide any benefit to use the macro on this place. If the package was renamed in the future, this would be the smallest change ... Thx for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
