https://bugzilla.redhat.com/show_bug.cgi?id=1341662 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- URL: should give the full URL to the upstream tarball, so it's possible to build the whole file from the spec file, and to verify that the tarball you have matches the upstream tarball. The build part (everything starting from "jekyll build") should be in the %build section. The kill part is indeed tough. My idea of putting 'jekyll serve' in the background does not work because it takes a while for jekyll to open the listening port, and we have to wait for that, but there's not synchronization mechanism. So using '--detach' seems like the only option. I'd do this: -------------------------------------------------------------------- diff --git fedora-developer-portal.spec fedora-developer-portal.spec index a711e0b05b..6ea026e24b 100644 --- fedora-developer-portal.spec +++ fedora-developer-portal.spec @@ -49,6 +49,8 @@ touch _includes/announcement.html gem install jekyll-lunr-js-search gem install jekyll-sitemap +%build + # Build the site and start server jekyll build jekyll serve --detach @@ -60,9 +62,7 @@ wget --convert-links -r http://127.0.0.1:4000/ || : mv 127.0.0.1\:4000/ fedora-developer-portal-content-%{shortcommit} # Kill server in the background -kill -9 `ps aux | grep jekyll | awk '{print $2}'` || : - -%build +pgrep -f 'jekyll serve --detach' | xargs kill %install mkdir -p %buildroot%{_bindir} --------------------------------------------------------------------- OK, let's concentrate on the deps. This package looks good. I'll add fedora-review+ when the deps are ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
