https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #6 from Frank Crawford <frank@xxxxxxxxxxxxxxxxxx> --- (In reply to Marek Cermak from comment #1) Marek, thanks for that. I've made a couple of comments below. > Package Review > ============== ... > > NOTES > ----- > - Orphaned package - name conflict permitted Obviously not an issue, it is the same package, so should be the same. > - For package ownership information, see : > > https://fedoraproject.org/wiki/Packaging: > Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your > _package_to_function or > https://fedoraproject.org/wiki/Packaging:WeakDependencies Mostly covered above, the only outstanding seems to be for /etc/cron.d, which I thought would be covered by crontabs, but seems to be owned by cronie. Any suggestions on what to do about that one, if anything? > - Correction of the spelling in specfile Yeah, will fix real errors here. (rsysusage -> sausage! :-)) > - Consider using %{?_isa} to fully define Requires Will review and probably fix it up. > - Consider putting content of Web App into /usr/share/%{name} instead of > /var/www/ See Comment 2 above. > - Change %doc LICENSE -> %license LICENSE Yep, will fix. > - Not necessary anymore to compare %if 0%{?fedora} > 17 Yep, will look at and probably remove. > - Rpmlint is complaining about the #%global comment - note that to escape > the whole macro, #%% is needed, also, it could actually be deleted > completely. Will review and fix up. As I said, thanks, I'll review and submit a new spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
