https://bugzilla.redhat.com/show_bug.cgi?id=1341662 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to František Zatloukal from comment #8) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #6) > > If you are still looking for a sponsor, I can do it — let me know if you are > > interested. > Sure, thanks! > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #6) > > It would be great if you could do (informal) reviews of two or three other > > packages from http://fedoraproject.org/PackageReviewStatus/NEW.html. > Ok, I can try it, should I just add comments with review and nothing else? Yes, look at the spec file and try to find issue and stuff that is wrong according to the guidelines. It's also good to run fedora-review (it's very strongly encouraged, especially if you're new to reviews), and look at all the stuff it says. That gives you a very good idea of what to check for. fedora-review builds the package in mock, and that is useful to verify that build dependencies are not missing. > I should have additional review requests ready by tomorrow if there are not > many issues (I am not very experienced packager after all... :) ). Great. > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > > jekyll serve & > > ... > > kill $! > > This didn't work (kill tried to kill completely different pid, not sure why > though). But this is working just fine: > jekyll serve --detach > pkill -f jekyll That's not idea, all solutions which grep the global process list are wrong. Consider the case where you're doing two parallel builds in mock for amd64 and i386 on the same machine: there are two jykylls running. But OK, upload the latest spec file you have, and I'll see if I can patch it to use $!. Otherwise we can ask for help on fedora-devel… I expect people to have had the same issue, e.g. in tests. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
