https://bugzilla.redhat.com/show_bug.cgi?id=1469531 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: 6429220659169c1e2172d61f9ca26335bc55ca0e0e5933fbfef60b8548fd55fa) is original. Ok. Summary verified from lib/Locale/Utils/PlaceholderMaketext.pm. Ok. Description verified from lib/Locale/Utils/PlaceholderMaketext.pm. Ok. License verified from lib/Locale/Utils/PlaceholderMaketext.pm and README. Ok. No XS code, noarch BuildArch is Ok. Test::Exception and Test::Perl::Critic and Test::Prereq::Build not used. Ok. All tests pass. Ok. $ rpmlint perl-Locale-Utils-PlaceholderMaketext.spec ../SRPMS/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.src.rpm ../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm perl-Locale-Utils-PlaceholderMaketext.src: W: spelling-error Summary(en_US) maketext -> make text, make-text, marketer perl-Locale-Utils-PlaceholderMaketext.src: W: spelling-error %description -l en_US maketext -> make text, make-text, marketer perl-Locale-Utils-PlaceholderMaketext.src: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-Locale-Utils-PlaceholderMaketext.noarch: W: spelling-error Summary(en_US) maketext -> make text, make-text, marketer perl-Locale-Utils-PlaceholderMaketext.noarch: W: spelling-error %description -l en_US maketext -> make text, make-text, marketer perl-Locale-Utils-PlaceholderMaketext.noarch: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext -rw-r--r-- 1 root root 696 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/Changes -rw-r--r-- 1 root root 751 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/README drwxr-xr-x 2 root root 0 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example -rw-r--r-- 1 root root 851 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/01_maketext_to_gettext.pl -rw-r--r-- 1 root root 793 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/02_gettext_to_maketext.pl -rw-r--r-- 1 root root 2570 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/11_expand_maketext.pl -rw-r--r-- 1 root root 1321 Jul 12 10:25 /usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/12_expand_gettext.pl -rw-r--r-- 1 root root 3022 Jul 12 10:25 /usr/share/man/man3/Locale::Utils::PlaceholderMaketext.3pm.gz drwxr-xr-x 2 root root 0 Jul 12 10:25 /usr/share/perl5/vendor_perl/Locale drwxr-xr-x 2 root root 0 Jul 12 10:25 /usr/share/perl5/vendor_perl/Locale/Utils -rw-r--r-- 1 root root 11295 Feb 24 14:28 /usr/share/perl5/vendor_perl/Locale/Utils/PlaceholderMaketext.pm File layout and Permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(Carp) 1 perl(Moo) >= 1.003001 1 perl(MooX::StrictConstructor) 1 perl(MooX::Types::MooseLike::Base) 1 perl(namespace::autoclean) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Locale::Utils::PlaceholderMaketext) = 1.003 1 perl-Locale-Utils-PlaceholderMaketext = 1.003-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. The package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20472804). Ok. The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
