https://bugzilla.redhat.com/show_bug.cgi?id=1341662 --- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Some notes on this package: - %description is supposed to say what the package does. It currently reads like an advertisement ;) Please include some down-to-earth description. > kill -9 `ps aux | grep jekyll | awk '{print $2}'` || : Yikes. You're assuming that there's just one jekyll running on the machine under this user. That's super brittle. There also shouldn't be any need to use -9. Maybe something like this instead: jekyll serve & ... kill $! The desktop file should be checked with desktop-file-validate or desktop-file-install, see https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
