https://bugzilla.redhat.com/show_bug.cgi?id=1468766 Ben Rosser <rosser.bjr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- > Strange that my rpmlint does not disclose the symbol issue otherwise I would have not wasted your time with another review scan. For whatever reason, rpmlint only picked that up when it scanned the installed package, not the RPM (both of which fedora-review does). Not entirely sure why. Anyway, I apologize, but I did one final review pass and there's one more thing that I missed initially. In addition to tinyxml, openzwave appears to bundle hidapi: https://github.com/OpenZWave/open-zwave/tree/master/cpp/hidapi. It may not be possible to unbundle, as it looks like upstream may have modified the tree themselves. If that's the case please add a bundled Provides to the spec as per https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
