https://bugzilla.redhat.com/show_bug.cgi?id=1463492 --- Comment #5 from s1061123@xxxxxxxxx --- (In reply to srakitnican from comment #4) > Just a few comments: > > 1. Missing changelog, see: > https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs > 2. The %defattr directive should not be used for default values, see: > https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > 3. Why do you need git for building? > 4. Empty and possibly wrongly located %post can be removed Hi srakitnican, Thank you for your comments! I am going to take care of all your comments and to test it. I will update the .spec and .SRPM after test completion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
