https://bugzilla.redhat.com/show_bug.cgi?id=1468766 --- Comment #1 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Issues: ======= - Dist tag is present. Please add _dist macro to the Release field. - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in libopenzwave See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries Note: this appears to be a false positive from fedora-review because the macros are located underneath %files. I think it can safely be ignored, but just inquired on #fedora-devel about it to be safe. - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 110735360 bytes in 2808 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - According to licensecheck, tinyxml sources appear to be bundled: zlib/libpng ----------- openzwave-1.4.164/cpp/tinyxml/tinyxml.cpp openzwave-1.4.164/cpp/tinyxml/tinyxml.h openzwave-1.4.164/cpp/tinyxml/tinyxmlerror.cpp openzwave-1.4.164/cpp/tinyxml/tinyxmlparser.cpp Please either unbundle and remove these files if they're not necessary, or add the appropriate Bundled provides and modify the License field accordingly to "LGPLv3+ and zlib" (https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries) - Binaries don't appear to be getting built with all hardening enabled: $ checksec --file ./MinOZW RELRO STACK CANARY NX PIE RPATH RUNPATH FORTIFY Fortified Fortifiable FILE Partial RELRO No canary found NX enabled No PIE No RPATH No RUNPATH No 0 2 ./MinOZW This suggests that compiler flags aren't being passed to the makefile. I suspect you need to explicitly pass %{optflags} and possibly %{__global_ldflags} to make in order to build with the right flags. - In a similar vein, it looks as if you haven't enabled parallel build in make. Is there a reason for this? - rpmlint warning: libopenzwave.x86_64: W: shared-lib-calls-exit /usr/lib64/libopenzwave.so.1.4 exit@GLIBC_2.2.5 This should probably be investigated and reported upstream. - rpmlint warning: libopenzwave.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libopenzwave.so.1.4 /lib64/libm.so.6 This may be a consequence of the compiler flags being wrong, but should likely also be investigated: https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
