[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1466961



--- Comment #6 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> ---
(In reply to Hannes Frederic Sowa from comment #5)
> Do I need to add a version to bundled(gnulib)? rpmlint complains right now.

Yes, I noticed that.  You can't add a version, as it doesn't have one.
I'd just note/explain the error in the spec file.

You don't need to remove buildroot in %install these days, but it doesn't hurt.
Also the packaging guidelines say not to use macros like %_rm

> Dave, I would love to make this package compatible to EPEL. I am going to
> read into that but feel free to dump any links on me. :)

I'll attach a patch.  I realize it's only really for el6, but _I think_ the
location for completions should be changed on others, as in the patch.
Otherwise the diff is mostly moot.  (I don't know if using pkg-config is the
right
way to get the completions directory.)  Handling completions should be in
packaging guidelines.
You do need to own the completions directories with %dir anyhow, which I
patched in.

Hope that helps, and apologies if I'm stepping on reviewer toes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux