https://bugzilla.redhat.com/show_bug.cgi?id=1466961 --- Comment #4 from Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx> --- (In reply to José Matos from comment #2) > Taking care of the review. > > According to fedora-review the package has the following issues: > > - Provides: bundled(gnulib) in place as required. > Note: Bundled gnulib but no Provides: bundled(gnulib) > See: > > http://fedoraproject.org/wiki/Packaging: > No_Bundled_Libraries#Requirement_if_you_bundle > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: info > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > - Package uses either %{buildroot} or $RPM_BUILD_ROOT > Note: Using both %{buildroot} and $RPM_BUILD_ROOT > See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros > > Could you comment/take care of this, please? I will. Thanks for the review. I upload a new specs and srpm new. I also should mention that this my first RPM in fedora, but I already found a sponsor (lrintel). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
