[Bug 1467762] Review Request: btrbk - Tool for creating snapshots and remote backups of btrfs subvolumes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1467762



--- Comment #5 from Mike Goodwin <mike@xxxxxxxxxxxx> ---
--- Updates ---

Git diff:
https://github.com/xenithorb/fedora-specs/commit/c30954cd2d4b3cfd6cf72b07d3f22ad3ee078b84

Spec URL:
https://raw.githubusercontent.com/xenithorb/fedora-specs/c30954cd2d4b3cfd6cf72b07d3f22ad3ee078b84/btrbk/btrbk.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/xenithorb/btrbk/fedora-rawhide-x86_64/00576171-btrbk/btrbk-0.25.0-3.fc27.src.rpm


--- Changelog ---

* Wed Jul  5 2017 Mike Goodwin <xenithorb@xxxxxxxxxxxxxxxxx> - 0.25.0-3
- License was GPLv3+ not GPLv3
- Add perl-generators for BuildRequires
- Add -p to all install commands in Makefile and in spec (with sed)
  - Patch submitted upstream: https://github.com/digint/btrbk/pull/164
- Fix if statement for RHEL detection
- Spelling of subvolumes -> sub-volumes to satisfy rpmlint
- Removed %%{?perl_default_filter} macro, unnecessary


--- RPMlint ---

btrbk.noarch: W: spelling-error Summary(en_US) btrfs -> barfs
btrbk.noarch: W: spelling-error %description -l en_US btrfs -> barfs
btrbk.src: W: spelling-error Summary(en_US) btrfs -> barfs
btrbk.src: W: spelling-error %description -l en_US btrfs -> barfs
2 packages and 1 specfiles checked; 0 errors, 4 warnings.


--- Notes ---

* As discussed on IRC, the systemd units provided with this software are for
cron-like purposes, and is explicitly NOT a daemon. It seems logical that
%{?systemd_requires} should be used, but not scriptlets that normally deal with
non-oneshot-timer service units. 

---

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux