https://bugzilla.redhat.com/show_bug.cgi?id=1467052 Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #11 from Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> --- Three things that caught my eyes: * You missed to add: `desktop-file-validate %{buildroot}/%{_datadir}/applications/*.desktop` in the %check section. * You can remove the install cmd in %install section, which creates the directories; the Makefile handles this now. * You are using %license with two files in a line and %doc with one file per line. Technically this is correct, I'd just fix it for the matter of keeping the same style across the spec file. *** Anyways, those are no real blockers and you can fix them during import. Package APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
