https://bugzilla.redhat.com/show_bug.cgi?id=1467322 --- Comment #2 from Josh Boyer <jwboyer@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > %global with_bundled is not used anywhere? > > > %{!?_licensedir:%global license %doc} > %license is defined everywhere now. Dropped both. > You've got an awful lot of macros that get used at most one time. > %provider_tld, really? So I copied this infrastructure from the buildah package. I believe the intention is to allow for different upstream repositories to be used by simply changing the macros rather than redefining every location in the spec. E.g. one could switch to pulling from a projectatomic.io repository in case there were changes needed before they are merged upstream. A number of the go-based container tools do this. > Looks OK, but I know nothing about go. New version of the spec and SRPM: Spec URL: https://jwboyer.fedorapeople.org/pub/manifest-tool.spec SRPM URL: https://jwboyer.fedorapeople.org/pub/manifest-tool-0.6.0-2.gita28af2b.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
