https://bugzilla.redhat.com/show_bug.cgi?id=1467052 Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |besser82@xxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #7 from Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> --- Some remarks on the spec file: * You are using `github_name` macro, although it seems `%github_name == %name`. This could be simplified, I think… * `%setup -qn %{github_name}-%{version}`: The %setup-macro shoud not be used anymore, execept you need to handle applying patches in a custom way. Using `%autosetup -p 1` is the preferred way now. * `install -m0644` should be `install -pm0644` to preserve timestamps. * You can create all needed dirs in a row within one invokation of `mkdir -p`: mkdir -p %{buildroot}%{_datadir}/appdata \ %{buildroot}%{_datadir}/icons/hicolor/{96x96,scalable}/apps * `%doc AUTHORS` should be `%license AUTHORS`, since AUTHORS is information that has a strong connection with licensing. * You might want to strip some 10 years old information from %changelog… *** Detailed review report will follow soon… -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
