https://bugzilla.redhat.com/show_bug.cgi?id=1467003 Guido Aulisi <guido.aulisi@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guido.aulisi@xxxxxxxxx --- Comment #1 from Guido Aulisi <guido.aulisi@xxxxxxxxx> --- Some informal comments: According to this guide https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B you should add BuildRequires: gcc You could use these macros: make %{?_smp_mflags} => %make_build make install DESTDIR=%{buildroot} => %make_install The %check section is for running tests, but the docs report that 'make check' doesn't execute any tests. Instead the user must run them manually with superuser privileges. The tests work together with the gpio-mockup kernel module which must be enabled. IMHO it's very difficult to execute such a test in mock or koji, so I would suggest to remove the %check section, and the --enable-tests configure option too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
