https://bugzilla.redhat.com/show_bug.cgi?id=1467527 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: f7d7626fffde98f85ec12c1ee26b01f139a4dddd2f453ea56c341df194e3210e) is original. Ok. Summary verified from lib/MooX/Singleton.pm. Ok. TODO: The description is not a sentence. I recommend rephrase it like `This is a Moo role that provides...' License verified in lib/MooX/Singleton.pm, README, and LICENSE. Ok. No XS code, noarch BuildArch is Ok. Test::Script is not used. Ok. Build-requires are Ok. All tests pass. Ok. $ rpmlint perl-MooX-Singleton.spec ../SRPMS/perl-MooX-Singleton-1.20-1.fc27.src.rpm ../RPMS/noarch/perl-MooX-Singleton-1.20-1.fc27.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MooX-Singleton-1.20-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Jul 4 11:20 /usr/share/doc/perl-MooX-Singleton -rw-r--r-- 1 root root 349 Apr 8 2013 /usr/share/doc/perl-MooX-Singleton/Changes -rw-r--r-- 1 root root 1152 Apr 8 2013 /usr/share/doc/perl-MooX-Singleton/README drwxr-xr-x 2 root root 0 Jul 4 11:20 /usr/share/licenses/perl-MooX-Singleton -rw-r--r-- 1 root root 18422 Apr 8 2013 /usr/share/licenses/perl-MooX-Singleton/LICENSE -rw-r--r-- 1 root root 1649 Jul 4 11:20 /usr/share/man/man3/MooX::Singleton.3pm.gz drwxr-xr-x 2 root root 0 Jul 4 11:20 /usr/share/perl5/vendor_perl/MooX -rw-r--r-- 1 root root 1834 Apr 8 2013 /usr/share/perl5/vendor_perl/MooX/Singleton.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MooX-Singleton-1.20-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(Role::Tiny) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-MooX-Singleton-1.20-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(MooX::Singleton) = 1.20 1 perl-MooX-Singleton = 1.20-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-MooX-Singleton-1.20-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20320188). Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
