https://bugzilla.redhat.com/show_bug.cgi?id=1466787 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source archive (SHA-256: bf1ff7b5d22e9fbaa37eafaa7bdef1997fbd853f1d893ebdcf75a360e67081ac) is original. Ok. Summary verified from lib/MooX/StrictConstructor.pm. Ok. Description verified from lib/MooX/StrictConstructor.pm. Ok. License verified from lib/Method/Generate/Constructor/Role/StrictConstructor.pm, lib/MooX/StrictConstructor.pm, and LICENSE. Ok. No XS code, noarch BuildArch is Ok. Pod::Coverage::TrustPod, Test::CPAN::Meta and Test::Pod not used. Ok. All tests pass. Ok. $ rpmlint perl-MooX-StrictConstructor.spec ../SRPMS/perl-MooX-StrictConstructor-0.008-1.fc27.src.rpm ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm perl-MooX-StrictConstructor.src: W: spelling-error %description -l en_US init -> unit, int, nit perl-MooX-StrictConstructor.noarch: W: spelling-error %description -l en_US init -> unit, int, nit 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Jul 3 17:05 /usr/share/doc/perl-MooX-StrictConstructor -rw-r--r-- 1 root root 1265 May 11 2015 /usr/share/doc/perl-MooX-StrictConstructor/Changes drwxr-xr-x 2 root root 0 Jul 3 17:05 /usr/share/licenses/perl-MooX-StrictConstructor -rw-r--r-- 1 root root 18358 May 11 2015 /usr/share/licenses/perl-MooX-StrictConstructor/LICENSE -rw-r--r-- 1 root root 1518 Jul 3 17:05 /usr/share/man/man3/Method::Generate::Constructor::Role::StrictConstructor.3pm.gz -rw-r--r-- 1 root root 2584 Jul 3 17:05 /usr/share/man/man3/MooX::StrictConstructor.3pm.gz drwxr-xr-x 2 root root 0 Jul 3 17:05 /usr/share/perl5/vendor_perl/Method drwxr-xr-x 2 root root 0 Jul 3 17:05 /usr/share/perl5/vendor_perl/Method/Generate drwxr-xr-x 2 root root 0 Jul 3 17:05 /usr/share/perl5/vendor_perl/Method/Generate/Constructor drwxr-xr-x 2 root root 0 Jul 3 17:05 /usr/share/perl5/vendor_perl/Method/Generate/Constructor/Role -rw-r--r-- 1 root root 2164 May 11 2015 /usr/share/perl5/vendor_perl/Method/Generate/Constructor/Role/StrictConstructor.pm drwxr-xr-x 2 root root 0 Jul 3 17:05 /usr/share/perl5/vendor_perl/MooX -rw-r--r-- 1 root root 4405 May 11 2015 /usr/share/perl5/vendor_perl/MooX/StrictConstructor.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(B) 1 perl(Class::Method::Modifiers) 1 perl(constant) 1 perl(Moo) >= 1.001000 1 perl(Moo::Role) 1 perl(strict) 1 perl(strictures) >= 1 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(feature)' (lib/Method/Generate/Constructor/Role/StrictConstructor.pm:27). $ rpm -q --provides -p ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Method::Generate::Constructor::Role::StrictConstructor) = 0.008 1 perl(MooX::StrictConstructor) = 0.008 1 perl-MooX-StrictConstructor = 0.008-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-MooX-StrictConstructor-0.008-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20307931). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
