https://bugzilla.redhat.com/show_bug.cgi?id=1467052 Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |besser82@xxxxxxxxxxxxxxxxx --- Comment #5 from Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> --- (In reply to Julien Enselme from comment #2) > It does. It also states for snapshot "An archive taken from upstream's > source code control system which is not associated with any release > version." Whereas here, it is associated to a version (2.0.0 to be precise). > Does it apply in this case? I tried to find a page explaining how release > should be made when we take the sources from github but didn't find any. I > though there was one. Do you have more info on this? If it is a associated to release version (git tag), then you do not need any specific additions to the release-version: Name: foo Version: X.Y.Z Release: 1%{?dist} URL: https://github.com/some_upstream/%{name} Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz It's pretty much the same way as with any other release-tarball, but if you are packaging from an arbitrary snapshot: %global commit 1234567890abcdef0987654321 %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commit_date YYYYMMDD %global git_ver git%{commit_date}.%{shortcommit} %global git_rel .%{git_ver} Name: foo Version: X.Y.Z Release: 0.1%{?git_rel}%{?dist} URL: https://github.com/some_upstream/%{name} Source0: %{url}/commit/%{commit}.tar.gz#/%{name}-%{version}-%{git_ver}.tar.gz I hope, I could clarify this a bit… -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
