https://bugzilla.redhat.com/show_bug.cgi?id=1467052 --- Comment #2 from Julien Enselme <jujens@xxxxxxxxx> --- > I believe this could cause problems if you want to update the package and the new commit shorthash turns out to be something that alphabetically comes before the old hash. I don't think so since the release number will increase (eg from 1 to 2). From my experience, this works fine. I maintain and use several packages that use this scheme and it works fine. > Either way, the versioning guidelines say that for snapshots, the Release: tag must contain a date. It does. It also states for snapshot "An archive taken from upstream's source code control system which is not associated with any release version." Whereas here, it is associated to a version (2.0.0 to be precise). Does it apply in this case? I tried to find a page explaining how release should be made when we take the sources from github but didn't find any. I though there was one. Do you have more info on this? > Also, the %{dist} tag should be %{?dist} (with a question mark). True. Fixed. - SPRM Url: https://dl.jujens.eu/SRPMS/gnome-password-generator-2.0.0-2.git0436b6d.fc26.src.rpm - SPEC Url: https://dl.jujens.eu/SPECS/gnome-password-generator.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
