https://bugzilla.redhat.com/show_bug.cgi?id=1411984 Ben Rosser <rosser.bjr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |rosser.bjr@xxxxxxxxx Flags| |fedora-review? --- Comment #22 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- In general the package looks very good! I have one blocking issue and a couple of comments/pointers. I am not a sponsor, but I can review the package, at which point you can file a ticket at https://pagure.io/packager-sponsors and ask for a sponsor. A sponsor will almost certainly ask you to do some reviews of other packages though before actually sponsoring you. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== - As per https://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files, you must mark any configuration files with %config or %config(noreplace). I see that there's an /etc/neofetch/config installed by the package; this should be marked as configuration. (Probably %config(noreplace)). Comments (non-blocking) ======================= - Your justification for using Recommends is fine but outdated; modern dnf _does_ install Recommends these days (but allows their removal without removing the main package, and also this behavior can be configured). - It certainly doesn't hurt, but you probably don't strictly need to condition on bash >= 3. Even RHEL5 has a bash at least this new. :) - The "wrong-script-interpreter" rpmlint messages are complaining because of the use of #!/usr/bin/env bash rather than just #!/bin/bash. Someting like this in %prep will fix this: sed 's,/usr/bin/env bash,%{_bindir}/bash,g' -i neofetch sed 's,/usr/bin/env bash,%{_bindir}/bash,g' -i config/config - Does the config file need a shebang? I assume it doesn't, since it appears neofetch simply sources the config to load it (https://github.com/dylanaraps/neofetch/blob/master/neofetch#L3604). If you remove it in %prep you can eliminate the other rpmlint error too. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 131 files have unknown license. Detailed output of licensecheck in /home/bjr/Programming/fedora/reviews/1411984-neofetch/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: neofetch-3.2.0-1.fc27.noarch.rpm neofetch-3.2.0-1.fc27.src.rpm neofetch.noarch: E: wrong-script-interpreter /usr/bin/neofetch /usr/bin/env bash neofetch.noarch: W: non-conffile-in-etc /etc/neofetch/config neofetch.noarch: E: wrong-script-interpreter /etc/neofetch/config /usr/bin/env bash neofetch.noarch: E: non-executable-script /etc/neofetch/config 644 /usr/bin/env bash 2 packages and 0 specfiles checked; 3 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory neofetch.noarch: W: non-conffile-in-etc /etc/neofetch/config neofetch.noarch: E: wrong-script-interpreter /etc/neofetch/config /usr/bin/env bash neofetch.noarch: E: non-executable-script /etc/neofetch/config 644 /usr/bin/env bash neofetch.noarch: E: wrong-script-interpreter /usr/bin/neofetch /usr/bin/env bash 1 packages and 0 specfiles checked; 3 errors, 1 warnings. Requires -------- neofetch (rpmlib, GLIBC filtered): /usr/bin/env bash Provides -------- neofetch: neofetch Source checksums ---------------- https://github.com/dylanaraps/neofetch/archive/3.2.0.tar.gz#/neofetch-3.2.0.tar.gz : CHECKSUM(SHA256) this package : 6aecd51c165a36692b4f6481b3071ab936aafc3fccffabbbfda140567f16431d CHECKSUM(SHA256) upstream package : 6aecd51c165a36692b4f6481b3071ab936aafc3fccffabbbfda140567f16431d Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1411984 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
