https://bugzilla.redhat.com/show_bug.cgi?id=1465817 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source archive (SHA-256: 48315c3716c66d86ef6dbd766a77d3f19f7d95bc47799bd0f0bc33ffe3563f05) is original. Ok. TODO: The package delivers more than Mail::Box::IMAP4. E.g. there is Mail::Server::IMAP4. Thus the summary and the description does not match the whole content. Either make the text more general or split the modules into subpackages with appropriate texts. Also the last "See also Mail::Server::IMAP4" sentence is not helpful because Mail::Server::IMAP4 is provided by this package. TODO: I recommend to subpackage Mail::Server::IMAP4* modules. License verified from lib/Mail/Transport/IMAP4.pod, lib/Mail/Box/IMAP4.pod, lib/Mail/Box/IMAP4/Message.pod, lib/Mail/Box/IMAP4/Head.pod, lib/Mail/Server/IMAP4.pod, lib/Mail/Server/IMAP4/Fetch.pod, lib/Mail/Server/IMAP4/List.pod, lib/Mail/Server/IMAP4/User.pod, and lib/Mail/Server/IMAP4/Search.pod. Ok. No XS code, noarch BuildArch is Ok. TODO: Build-require `perl(:VERSION) >= 5.10' (Makefile.PL:3). FIX: Do not build-require `perl(Mail::Server)'. The only occurrence is at lib/Mail/Server/IMAP4.pm:13 and this is not used when running the tests. All tests pass. Ok. $ rpmlint perl-Mail-Box-IMAP4.spec ../SRPMS/perl-Mail-Box-IMAP4-3.001-1.fc27.src.rpm ../RPMS/noarch/perl-Mail-Box-IMAP4-3.001-1.fc27.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Mail-Box-IMAP4-3.001-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Jun 28 15:03 /usr/share/doc/perl-Mail-Box-IMAP4 -rw-r--r-- 1 root root 254 Feb 2 16:02 /usr/share/doc/perl-Mail-Box-IMAP4/ChangeLog -rw-r--r-- 1 root root 817 Feb 2 16:02 /usr/share/doc/perl-Mail-Box-IMAP4/README -rw-r--r-- 1 root root 9199 Jun 28 15:03 /usr/share/man/man3/Mail::Box::IMAP4.3pm.gz -rw-r--r-- 1 root root 3715 Jun 28 15:03 /usr/share/man/man3/Mail::Box::IMAP4::Head.3pm.gz -rw-r--r-- 1 root root 8089 Jun 28 15:03 /usr/share/man/man3/Mail::Box::IMAP4::Message.3pm.gz -rw-r--r-- 1 root root 2388 Jun 28 15:03 /usr/share/man/man3/Mail::Server::IMAP4.3pm.gz -rw-r--r-- 1 root root 3040 Jun 28 15:03 /usr/share/man/man3/Mail::Server::IMAP4::Fetch.3pm.gz -rw-r--r-- 1 root root 3252 Jun 28 15:03 /usr/share/man/man3/Mail::Server::IMAP4::List.3pm.gz -rw-r--r-- 1 root root 3314 Jun 28 15:03 /usr/share/man/man3/Mail::Server::IMAP4::Search.3pm.gz -rw-r--r-- 1 root root 6263 Jun 28 15:03 /usr/share/man/man3/Mail::Server::IMAP4::User.3pm.gz -rw-r--r-- 1 root root 7080 Jun 28 15:03 /usr/share/man/man3/Mail::Transport::IMAP4.3pm.gz drwxr-xr-x 2 root root 0 Jun 28 15:03 /usr/share/perl5/vendor_perl/Mail drwxr-xr-x 2 root root 0 Jun 28 15:03 /usr/share/perl5/vendor_perl/Mail/Box drwxr-xr-x 2 root root 0 Jun 28 15:03 /usr/share/perl5/vendor_perl/Mail/Box/IMAP4 -rw-r--r-- 1 root root 8198 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Box/IMAP4.pm -rw-r--r-- 1 root root 22766 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Box/IMAP4.pod -rw-r--r-- 1 root root 1308 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Box/IMAP4/Head.pm -rw-r--r-- 1 root root 7541 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Box/IMAP4/Head.pod -rw-r--r-- 1 root root 3917 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Box/IMAP4/Message.pm -rw-r--r-- 1 root root 21656 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Box/IMAP4/Message.pod drwxr-xr-x 2 root root 0 Jun 28 15:03 /usr/share/perl5/vendor_perl/Mail/Server drwxr-xr-x 2 root root 0 Jun 28 15:03 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4 -rw-r--r-- 1 root root 487 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4.pm -rw-r--r-- 1 root root 2757 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4.pod -rw-r--r-- 1 root root 7744 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/Fetch.pm -rw-r--r-- 1 root root 3696 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/Fetch.pod -rw-r--r-- 1 root root 2920 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/List.pm -rw-r--r-- 1 root root 4661 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/List.pod -rw-r--r-- 1 root root 444 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/Search.pm -rw-r--r-- 1 root root 5631 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/Search.pod -rw-r--r-- 1 root root 3199 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/User.pm -rw-r--r-- 1 root root 14452 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Server/IMAP4/User.pod drwxr-xr-x 2 root root 0 Jun 28 15:03 /usr/share/perl5/vendor_perl/Mail/Transport -rw-r--r-- 1 root root 13393 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Transport/IMAP4.pm -rw-r--r-- 1 root root 14399 Feb 2 16:02 /usr/share/perl5/vendor_perl/Mail/Transport/IMAP4.pod File layout and permissions are Ok. $ rpm -q --req[test@fedora-27 SPECS]$ rpm -q --requires -p ../RPMS/noarch/perl-Mail-Box-IMAP4-3.001-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(base) 1 perl(Date::Parse) 1 perl(Digest::HMAC_MD5) 1 perl(Digest::MD5) 1 perl(List::Util) 1 perl(Mail::Box::IMAP4::Head) 1 perl(Mail::Box::IMAP4::Message) 1 perl(Mail::Box::Manage::User) >= 3 1 perl(Mail::Box::Net) >= 3 1 perl(Mail::Box::Net::Message) 1 perl(Mail::Box::Parser::Perl) 1 perl(Mail::Box::Search) >= 3 1 perl(Mail::IMAPClient) 1 perl(Mail::Message) >= 3 1 perl(Mail::Message::Body::Lines) >= 3 1 perl(Mail::Message::Head) 1 perl(Mail::Message::Head::Complete) >= 3 1 perl(Mail::Message::Head::Delayed) >= 3 1 perl(Mail::Server) >= 3 1 perl(Mail::Server::IMAP4::Fetch) 1 perl(Mail::Server::IMAP4::List) 1 perl(Mail::Server::IMAP4::Search) 1 perl(Mail::Transport::IMAP4) 1 perl(Mail::Transport::Receive) >= 3 1 perl(Scalar::Util) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: The `Mail::Message' is not used directly anywhere in the library. Do not run-require it. Mail::Message::Body::Lines is used from lib/Mail/Box/IMAP4.pm:56. Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Mail-Box-IMAP4-3.001-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Mail::Box::IMAP4) = 3.001 1 perl(Mail::Box::IMAP4::Head) = 3.001 1 perl(Mail::Box::IMAP4::Message) = 3.001 1 perl(Mail::Server::IMAP4) = 3.001 1 perl(Mail::Server::IMAP4::Fetch) = 3.001 1 perl(Mail::Server::IMAP4::List) = 3.001 1 perl(Mail::Server::IMAP4::Search) = 3.001 1 perl(Mail::Server::IMAP4::User) = 3.001 1 perl(Mail::Transport::IMAP4) = 3.001 1 perl-Mail-Box-IMAP4 = 3.001-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Mail-Box-IMAP4-3.001-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20226839). Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' items and consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
